replace links in howto/pyporting.rst with sphinx references#17781
Merged
Conversation
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
csabella
approved these changes
Jan 5, 2020
csabella
left a comment
csabella
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for the contribution!
Contributor
|
GH-17844 is a backport of this pull request to the 3.8 branch. |
|
GH-17845 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 5, 2020
miss-islington
added a commit
that referenced
this pull request
Jan 5, 2020
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com> (cherry picked from commit e6ae90d) Co-authored-by: Oleg Höfling <hoefling@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jan 5, 2020
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com> (cherry picked from commit e6ae90d) Co-authored-by: Oleg Höfling <hoefling@users.noreply.github.com>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
…-17781) Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
howto/pyporting.rstdocumentation uses hardcoded links to internal pages. This results in minor rendering issues. This change replaces the hardcoded links with suitable Sphinx roles.This is the second and last PR that replaces hardcoded links to internal pages (the first one was #11730). I did create neither an issue on BPO nor a news entry as the fix is IMO a trivial one.